Resolve with array instead of SplObjectStorage (AdapterInterface::ls(), Node\DirectoryInterface::lsRecursive(), Node\NodeInterface::copy, ObjectStreamSink::promise())#58
Merged
WyriHaximus merged 2 commits intomasterfrom Jan 24, 2019
unknown repository
Merged
Resolve with array instead of SplObjectStorage (AdapterInterface::ls(), Node\DirectoryInterface::lsRecursive(), Node\NodeInterface::copy, ObjectStreamSink::promise())#58WyriHaximus merged 2 commits intomasterfrom unknown repository
WyriHaximus merged 2 commits intomasterfrom
unknown repository
Conversation
jsor
approved these changes
Jan 24, 2019
WyriHaximus
approved these changes
Jan 24, 2019
clue
requested changes
Jan 24, 2019
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
Thanks for filing this PR, I agree that using an array makes much more sense here 👍
It looks like this is only a minor change in the internal APIs, but this seems to have a bigger impact on the user-facing APIs. I'm fine with this change, but can we get a list of affected functions for our upgrade guides and ensure they are all covered? Accordingly, docs and examples might have to be updated, e.g. https://github.com/reactphp/filesystem#list-contents.
Author
|
Affected by this change are the following methods:
|
clue
approved these changes
Jan 24, 2019
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@CharlotteDunois Thanks for the quick update, LGTM! 👍
clue
changed the title
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the comments of #57 - this PR changes
ObjectStreamSink::promiseto resolve with an array, instead of an unexpectedSplObjectStorage.